chore(metrics): Refactor current metrics #185

Evalir · 2025-11-25T12:31:18Z

We're not following our set pattern for metrics (see node-components) and it makes it hard to know what we're really tracking and where.

Evalir · 2025-11-25T12:31:35Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

fix(cache): do not re-initialize basefee on each loop #186
chore(metrics): Refactor current metrics #185 👈 (View in Graphite)
fix(flashbots): Do not block on submission #184
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

prestwich · 2025-11-25T16:52:44Z

src/tasks/block/sim.rs

-        counter!("signet.builder.built_blocks").increment(1);
-        histogram!("signet.builder.built_blocks.tx_count").record(built_block.tx_count() as u32);
+        metrics::built_blocks().increment(1);
+        metrics::built_blocks_tx_count().record(built_block.tx_count() as u32);


these lines should both be collapsed into metrcis::record_bulit_block(&block) and the logic to increment, etc should be in the metrics file

prestwich

this is lowkey a NACK from me rn. this work predates our current metrics pattern. the new work doesn't follow our pattern, and adds metrics we don't necessariy want. is there a design doc for this I'm not seeing?

prestwich · 2025-11-25T16:53:10Z

src/tasks/submit/flashbots.rs

    /// Logs a debug message if the channel is closed.
    fn track_outbound_tx(&self, envelope: &alloy::consensus::TxEnvelope) {
-        counter!("signet.builder.flashbots.").increment(1);
+        metrics::flashbots_submissions().increment(1);


ditto here. we don't want the caller to be responsible for the .increment(1), as it requires knowing the metric semantics

prestwich · 2025-11-25T16:53:14Z

src/tasks/submit/flashbots.rs

            // Don't submit empty blocks
            if sim_result.block.is_empty() {
-                counter!("signet.builder.flashbots.empty_block").increment(1);
+                metrics::flashbots_empty_blocks().increment(1);


prestwich · 2025-11-25T16:53:21Z

src/tasks/submit/flashbots.rs

            let result =
                self.prepare(&sim_result).instrument(span.clone()).await.inspect_err(|error| {
-                    counter!("signet.builder.flashbots.bundle_prep_failures").increment(1);
+                    metrics::flashbots_bundle_prep_failures().increment(1);


prestwich · 2025-11-25T16:53:35Z

src/tasks/submit/flashbots.rs

                    .instrument(submit_span.clone())
                    .await;

+                metrics::flashbots_submission_duration_ms()


prestwich · 2025-11-25T16:53:46Z

src/tasks/submit/flashbots.rs

                match response {
                    Ok(resp) => {
-                        counter!("signet.builder.flashbots.bundles_submitted").increment(1);
+                        metrics::flashbots_bundles_submitted().increment(1);


prestwich · 2025-11-25T16:54:05Z

src/tasks/submit/prep.rs

+                    .inspect(|_| {
+                        metrics::quincey_signature_duration_ms()
+                            .record(start.elapsed().as_millis() as f64);
+                        metrics::quincey_signatures().increment(1);


prestwich · 2025-11-25T16:54:09Z

src/tasks/submit/prep.rs

                    .inspect_err(|_| {
-                        counter!("signet.builder.quincey_signature_failures").increment(1)
+                        metrics::quincey_signature_duration_ms()
+                            .record(start.elapsed().as_millis() as f64);


prestwich · 2025-11-25T16:54:13Z

src/tasks/submit/prep.rs

-                        counter!("signet.builder.quincey_signature_failures").increment(1)
+                        metrics::quincey_signature_duration_ms()
+                            .record(start.elapsed().as_millis() as f64);
+                        metrics::quincey_signature_failures().increment(1);


prestwich · 2025-11-25T16:54:41Z

src/tasks/submit/prep.rs

+                .provider
+                .get_transaction_count(self.provider.default_signer_address())
+                .into_future()
+                .instrument(debug_span!("nonce_fetch"))


what exactly is this span doing? it records no info and has no real parent

prestwich · 2025-11-25T16:55:01Z

src/tasks/submit/prep.rs

+                .into_future()
+                .instrument(debug_span!("nonce_fetch"))
+                .await?;
+            metrics::nonce_fetch_duration_ms().record(start.elapsed().as_millis() as f64);


what is this metric for? why do we want to track this?

prestwich · 2025-11-25T16:56:05Z

src/tasks/metrics.rs

                    // record how long it took to mine the transaction
                    // potential improvement: use the block timestamp to calculate the time elapsed
-                    histogram!("metrics.tx_mine_time").record(start.elapsed().as_millis() as f64);
+                    metrics::tx_mine_time_ms().record(start.elapsed().as_millis() as f64);


prestwich · 2025-11-25T16:56:08Z

src/tasks/metrics.rs

                    // log whether the transaction reverted
                    if receipt.status() {
-                        counter!("metrics.tx_succeeded").increment(1);
+                        metrics::tx_succeeded().increment(1);


prestwich · 2025-11-25T16:56:10Z

src/tasks/metrics.rs

                        debug!("tx succeeded");
                    } else {
-                        counter!("metrics.tx_reverted").increment(1);
+                        metrics::tx_reverted().increment(1);


prestwich · 2025-11-25T16:56:14Z

src/tasks/metrics.rs

                Err(PendingTransactionError::TxWatcher(WatchTxError::Timeout)) => {
                    // log that the transaction timed out
-                    counter!("metrics.tx_not_mined").increment(1);
+                    metrics::tx_not_mined().increment(1);


prestwich · 2025-11-25T16:56:17Z

src/tasks/metrics.rs

                }
                Err(e) => {
-                    counter!("metrics.rpc_error").increment(1);
+                    metrics::rpc_error().increment(1);


chore(metrics): Refactor current metrics

22ea7e5

We're not following our set pattern for metrics (see node-components) and it makes it hard to know what we're really tracking and where.

Evalir requested review from dylanlott and prestwich as code owners November 25, 2025 12:31

Evalir mentioned this pull request Nov 25, 2025

fix(flashbots): Do not block on submission #184

Open

feat: track flashbots submission duration

ef767a9

Evalir mentioned this pull request Nov 25, 2025

fix(cache): do not re-initialize basefee on each loop #186

Open

prestwich reviewed Nov 25, 2025

View reviewed changes

prestwich requested changes Nov 25, 2025

View reviewed changes

prestwich reviewed Nov 25, 2025

View reviewed changes

src/tasks/metrics.rs

}

Err(e) => {

counter!("metrics.rpc_error").increment(1);

metrics::rpc_error().increment(1);

Copy link

Member

prestwich Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

chore(metrics): Refactor current metrics #185

Are you sure you want to change the base?

chore(metrics): Refactor current metrics #185

Conversation

Evalir commented Nov 25, 2025

Uh oh!

Evalir commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prestwich left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Evalir commented Nov 25, 2025 •

edited

Loading